Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@joakim-noah
Copy link
Contributor

Pull in some necessary declarations from bionic, exclude some CRuntime_Glibc definitions, add ARM support extracted from my work with ldc, and replace all uses of Android with CRuntime_Bionic or linux.

CRuntime_Bionic or linux, and use CRuntime_Glibc where
appropriate.
exclude some Glibc definitions, and add __tls_get_addr for ARM.
@joakim-noah
Copy link
Contributor Author

Ping, no problems with the auto-tester for three weeks. I think this and #1384, which has been sitting for more than five months, can be merged.

@dnadlinger
Copy link
Contributor

Auto-merge toggled on

@dnadlinger
Copy link
Contributor

Not too fond of duplicating function implementations, though. I get Walter's/… point of making platform support explicit for bindings, but at some point, it must be better to use a common implementation to avoid code duplication.

@joakim-noah
Copy link
Contributor Author

I'd like to get this and a couple other PRs merged into the ldc branches. Should I do that or would you prefer to do it?

dnadlinger added a commit that referenced this pull request Feb 23, 2016
@dnadlinger dnadlinger merged commit 123fca9 into dlang:master Feb 23, 2016
@dnadlinger
Copy link
Contributor

Just go ahead and merge it, I'd say.

@joakim-noah
Copy link
Contributor Author

Regarding function implementations, I guess you're talking about __tls_get_addr? The two function prototypes are slightly different, because X86 uses an extra underscore and I think the dmd patch dereferences the passed-in pointer, so only the last three lines are the same. Rather than extract those out, I just cut-n-pasted it.

@dnadlinger
Copy link
Contributor

Ah, thanks, I see now – it was quite late at night, and they looked visually similar.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants