This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Properly free module info when using linker-generated section brackets #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently-merged support for linker-generated section brackets (#1379) causes a segfault on Android, when
rt_termtries to free module info that is no longer malloced. I'm guessing it broke for Solaris too, though I haven't tested it. This PR seems to fix it- all druntime and phobos tests on Android/x86 and linux/x86 pass locally- let me know if any further tweaks are necessary.