skipOver: no unnecessary decoding #2986
Conversation
andralex
force-pushed
the
master
branch
2 times, most recently
from
d8a62b0 to
9dee314
Compare
std/algorithm/searching.d
Outdated
There was a problem hiding this comment.
Should this be extended to all T[]?
There was a problem hiding this comment.
I'm thinking the generated code should be already good for T[]s, isn't it?
There was a problem hiding this comment.
Your string version would be better for things like int[] and float[] as well since I believe the meat of the function would be vectorized. Probably best to extend.
There was a problem hiding this comment.
OK, good idea. Will do.
|
LGTM. As in: I think I understand what you do, why you do it and why it makes sense. |
std/algorithm/searching.d
Outdated
There was a problem hiding this comment.
The other, non-string version of the function doesn't have this length check fast path. Could you add it for when both ranges have lengths?
|
|
|
thanks for the review - updated |
There was a problem hiding this comment.
Is the overload needed instead of a default pred?
There was a problem hiding this comment.
I'm leaving it like that pending future improvements based on equality.
|
ping |
|
LGTM. |
|
Auto-merge toggled on |
skipOver: no unnecessary decoding
6 participants
Per title. No need to do decoding if comparing two strings that have the same representation.