Define server team role #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2018 11:28
Create server role ClassDB_Team and grant the new role to ClassDB role
Accounted for function ClassDB.hasClassDBRole
afig
approved these changes
Jun 12, 2018
Contributor
afig
left a comment
afig
left a comment
There was a problem hiding this comment.
Looks good to merge. The ClassDB_Team role is properly added, verified, and removed.
Closed
wildtayne
approved these changes
Jun 12, 2018
Contributor
wildtayne
left a comment
wildtayne
left a comment
There was a problem hiding this comment.
Everything looks/works good
KevinKelly25
approved these changes
Jun 12, 2018
Contributor
KevinKelly25
left a comment
KevinKelly25
left a comment
There was a problem hiding this comment.
The changes look good. The only very small issue I see is in a comment in addHelpersCore.sql Ln 152. Where it should also include 'classdb_team'
Member
Author
|
Thank you all for reviewing. I have addressed the omission @KevinKelly25 pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR add a new server role
ClassDB_Teamin preparation for team support. User and ClassDB role management need the server role to support teams. (Those changes are and should be subject of another PR).