Update and improve privilege tests (M3) #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts adding tests to the privileges test suite in regards to the new teams functionality. More work still needs to be done.
Uses psql's \setenv flag to automatically set a password for the user being connected with. The original user is now stored instead of assuming the postgres user.
Involved fixing typos, updating API, and removing type casting to prevent a NOTICE from being raised.
KevinKelly25
approved these changes
Jun 23, 2018
Contributor
KevinKelly25
left a comment
KevinKelly25
left a comment
There was a problem hiding this comment.
All the privilege tests pass/fail as expected for me. Looks good to merge
wildtayne
approved these changes
Jun 23, 2018
Contributor
wildtayne
left a comment
wildtayne
left a comment
There was a problem hiding this comment.
Everything here looks good to merge, thanks.
afig
changed the title
Contributor
Author
|
Thanks for the reviews everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the privilege tests to also test privileges on newly added functions. The tests are still not perfect, but they are gradually improving.
In addition to expanding the objects tested, the main script has also been updated to not require the user to enter a password for every connection to the database. The tests also store who the original user was rather than assuming it was the
postgresrole. Thanks to work that @srrollo and @smurthys performed in PR #214 for these fixes.Closes: #207, Closes: #222