Skip to content

Conversation

@theodesp
Copy link
Collaborator

No description provided.

@l3pp4rd
Copy link
Member

l3pp4rd commented Feb 28, 2019

well, makes sense in a way. but there is an issue with that. go mod will lookup mysql as a dependency, which would cause it as a requirement for this library (unless I missing something). And in general the library has no dependencies.
So in the end I think it would be better to leave it as is, because it is an obvious error and user who wants to test the example would just figure this out.

The readme change is fine.

@theodesp
Copy link
Collaborator Author

OK I will keep the Readme change and remove the other ones

@theodesp
Copy link
Collaborator Author

@l3pp4rd PR updated

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          13       13           
  Lines         720      720           
=======================================
  Hits          657      657           
  Misses         44       44           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7699b...314ebd6. Read the comment docs.

@l3pp4rd l3pp4rd merged commit 3f9954f into DATA-DOG:master Mar 1, 2019
@l3pp4rd
Copy link
Member

l3pp4rd commented Mar 1, 2019

thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants