Fixed some typos #165
Merged
Fixed some typos #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodesp
commented
Feb 27, 2019
| ni.Integer, ni.Valid = 0, false | ||
| case int64: | ||
| const maxUint = ^uint(0) | ||
| const minUint = 0 |
Member
|
Hi, I think you made a typo somewhere and it is not longer parseable source code, check the travis report |
theodesp
commented
Feb 28, 2019
rows.go
Outdated
| // column string to a []byte representation. Currently | ||
| // transforms NULL to nil | ||
| var CSVColumnParser = func(s string) []byte { | ||
| var CSVColumnParser = func(s string) []bytezzx { |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 13 13
Lines 720 720
=======================================
Hits 657 657
Misses 44 44
Partials 19 19
Continue to review full report at Codecov.
|
Member
|
thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typos and some test case strings