Skip to content

Conversation

@krevels
Copy link
Contributor

@krevels krevels commented Jun 4, 2019

This provides support for the usage of sql.Out parameters with the sqlmock driver. While this partially addresses #144 , it should be noted that this isn't a matcher for sql.Out values, and users will likely have to use a custom matcher or AnyArg() for now.

@@ -0,0 +1,11 @@
// +build go1.8,!go1.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to preserve the CheckNamedValue functionality for 1.8, but provide my own for 1.9+. I wasn't sure if there was a better way to handle doing that though 😅

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #174 into master will decrease coverage by 0.6%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   91.25%   90.64%   -0.61%     
==========================================
  Files          13       15       +2     
  Lines         720      727       +7     
==========================================
+ Hits          657      659       +2     
- Misses         44       49       +5     
  Partials       19       19
Impacted Files Coverage Δ
sqlmock_go18.go 100% <ø> (ø) ⬆️
sqlmock_go18_19.go 0% <0%> (ø)
sqlmock_go19.go 71.42% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0bdf2...470c520. Read the comment docs.

@l3pp4rd l3pp4rd merged commit 7500eca into DATA-DOG:master Jun 5, 2019
@l3pp4rd
Copy link
Member

l3pp4rd commented Jun 5, 2019

good change, thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants