-
Notifications
You must be signed in to change notification settings - Fork 4
Small improvements in Historicizing Games' index.qmd #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the conference program page by adjusting heading levels for improved structure, expanding the "Speakers’ Guide" tab with comprehensive travel information, and reformatting the "Call for papers" section using semantic headings. No changes were made to exported or public entities. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd (1)
567-567: Typo: truncated word “ntations”
Line readsntations and round tables will be conducted in English.– should be “Presentations”.-ntations and round tables will be conducted in English. +Presentations and round tables will be conducted in English.
🧹 Nitpick comments (2)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd (2)
96-96: Inline style on new<h2>is fine, but consider moving it to CSS for maintainability
Hard-codingstyle="text-align:center;"makes future visual adjustments harder and scatters presentation concerns through the document. A small utility class (e.g.,.text-center) or an existing Bootstrap helper would keep markup cleaner.
535-545: Speaker-travel section would benefit from semantic lists and consistent linking
The three “By …” statements read better as a bullet list; they also currently mix linked and plainsbb.chreferences. Re-structure for readability and UX:-### Getting to Bern - -By train: Travel to Bern station. For timetables and tickets, visit [sbb.ch](https://sbb.ch) or use [this (very good) app](https://www.sbb.ch/en/travel-information/apps/sbb-mobile.html). -By plane: Arrival via Geneva, Zurich, or Basel airports. Direct trains connect with Bern at least once an hour from Zurich and Basel. For train timetables and tickets, visit sbb.ch. - -By car: If you plan to use the highway, remember to purchase the national yearly vignette at the border (40 CHF). +### Getting to Bern + +- **By train** – Travel to Bern station. See the [SBB timetable](https://sbb.ch) or the [SBB Mobile app](https://www.sbb.ch/en/travel-information/apps/sbb-mobile.html). +- **By plane** – Fly to Geneva, Zurich, or Basel; direct trains run to Bern at least hourly. Check the [SBB timetable](https://sbb.ch) for details. +- **By car** – Swiss motorways require a yearly vignette (CHF 40) available at the border.Cleaner semantics, identical information.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build, Optimize, and Upload Artifacts
🔇 Additional comments (1)
content/projects/ch-ludens/20250911-historicizing-GAMES/index.qmd (1)
549-552: Duplicate H2/H3 titles may confuse screen-readers and SEO
The CFP tab repeats the global title/subtitle already defined in the page front-matter and on the “Home” tab. Consider downgrading these to H3/H4 inside the tab or omitting them to avoid multiple identical headings in one document outline.
vvvyyynet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Pull request
Proposed changes
Types of changes
Checklist
Summary by CodeRabbit