fix: use extension-aware Config discovery in testing fixture #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `with_config_repo` fixture was directly importing Config from diracx.core.config, bypassing the extension discovery system. This caused a mismatch when extensions like gubbins add fields to Config - the fixture would create test data with the base schema, but ConfigSource would later try to validate it with the extended schema. Now uses select_from_extension() to discover the correct Config class, consistent with how ConfigSource.read_raw() works.
chaen
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
with_config_repofixture was directly importingConfigfromdiracx.core.config, bypassing the extension discovery systemConfigSourcewould later try to validate it with the extended schemaselect_from_extension()to discover the correct Config class, consistent with howConfigSource.read_raw()works