refactor: use arrow function

Author: TonyRL

.oxlintrc.json

@@ -360,6 +360,22 @@
             {
                 "selector": "CallExpression[callee.name=\"load\"] AwaitExpression > CallExpression",
                 "message": "Do not use await in call expressions. Extract the result into a variable first."
+            },
+            {
+                "selector": "Identifier[name=\"_ctx\"]",
+                "message": "Usage of `_ctx` is not allowed."
+            },
+            {
+                "selector": "CallExpression[callee.property.name=\"each\"] > FunctionExpression",
+                "message": "Use an arrow function instead."
+            },
+            {
+                "selector": "CallExpression[callee.property.name=\"filter\"] > FunctionExpression",
+                "message": "Use an arrow function instead."
+            },
+            {
+                "selector": "CallExpression[callee.property.name=\"map\"] > FunctionExpression",
+                "message": "Use an arrow function instead."
             }
         ],
 

lib/middleware/anti-hotlink.ts

@@ -59,13 +59,13 @@ const replaceUrl = (template?: string, url?: string) => {
 };
 
 const replaceUrls = ($: CheerioAPI, selector: string, template: string, attribute = 'src') => {
-    $(selector).each(function () {
-        const oldSrc = $(this).attr(attribute);
+    $(selector).each((_, el) => {
+        const oldSrc = $(el).attr(attribute);
         if (oldSrc) {
             const url = parseUrl(oldSrc);
             if (url && url.protocol !== 'data:') {
                 // Cheerio will do the right thing to prohibit XSS.
-                $(this).attr(attribute, interpolate(template, url));
+                $(el).attr(attribute, interpolate(template, url));
             }
         }
     });

lib/routes/163/exclusive.ts

@@ -163,10 +163,10 @@ async function handler(ctx) {
 
                         content('.m-linkCard').remove();
 
-                        content('.m-photo').each(function () {
-                            content(this).html(
+                        content('.m-photo').each((_, el) => {
+                            content(el).html(
                                 renderExclusiveDescription({
-                                    image: content(this).find('img').attr('data-src'),
+                                    image: content(el).find('img').attr('data-src'),
                                 })
                             );
                         });

lib/routes/163/news/rank.ts

@@ -167,8 +167,8 @@ async function handler(ctx) {
                     const content = load(detailResponse.data);
 
                     content('.bot_word, .js-open-app, .s-img').remove();
-                    content('video').each(function () {
-                        content(this).attr('src', content(this).attr('data-src'));
+                    content('video').each((_, el) => {
+                        content(el).attr('src', content(el).attr('data-src'));
                     });
                     content('.article-body .image-lazy').each((_, elem) => {
                         elem.attribs.src = elem.attribs['data-src'] ?? elem.attribs.src;

lib/routes/2048/index.tsx

@@ -133,13 +133,13 @@ async function handler(ctx) {
 
                 content('.ads, .tips').remove();
 
-                content('ignore_js_op').each(function () {
-                    const img = content(this).find('img');
+                content('ignore_js_op').each((_, el) => {
+                    const img = content(el).find('img');
                     const originalSrc = img.attr('data-original');
                     const fallbackSrc = img.attr('src');
                     // 判断是否有 data-original 属性，若有则使用其值，否则使用 src 属性值
                     const imgSrc = originalSrc || fallbackSrc;
-                    content(this).replaceWith(`<img src="${imgSrc}">`);
+                    content(el).replaceWith(`<img src="${imgSrc}">`);
                 });
 
                 item.author = content('.fl.black').first().text();
@@ -174,8 +174,8 @@ async function handler(ctx) {
                     }
                 }
 
-                content('.showhide img').each(function () {
-                    readTpc.append(`<br><img style="max-width: 100%;" src="${content(this).attr('src')}">`);
+                content('.showhide img').each((_, el) => {
+                    readTpc.append(`<br><img style="max-width: 100%;" src="${content(el).attr('src')}">`);
                 });
 
                 item.description = readTpc.html();

lib/routes/8264/list.tsx

@@ -129,11 +129,11 @@ async function handler(ctx) {
 
                 const pubDate = content('span.pub-time').text() || content('span.fby span').first().prop('title') || content('span.fby').first().text().split('发表于').pop().trim();
 
-                content('img').each(function () {
-                    content(this).replaceWith(
+                content('img').each((_, el) => {
+                    content(el).replaceWith(
                         renderToString(
                             <figure>
-                                <img src={content(this).prop('file')} alt={content(this).prop('alt')} />
+                                <img src={content(el).prop('file')} alt={content(el).prop('alt')} />
                             </figure>
                         )
                     );

lib/routes/abc/index.ts

@@ -105,8 +105,8 @@ async function handler(ctx) {
 
                     content('#body *, div[data-component="FeatureMedia"]')
                         .children()
-                        .each(function () {
-                            const element = content(this);
+                        .each((_, el) => {
+                            const element = content(el);
                             if (element.prop('tagName').toLowerCase() === 'figure') {
                                 element.replaceWith(
                                     renderDescription({

lib/routes/abskoop/index.ts

@@ -48,8 +48,8 @@ async function handler(ctx) {
                 $detail('article.post-content').find('.lwptoc').remove();
                 $detail('article.post-content').find('#related_posts').remove();
                 $detail('article.post-content').find('.entry-copyright').remove();
-                $detail('article.post-content img').each(function () {
-                    $detail(this).replaceWith(`<img src=https:${$detail(this).attr('src')}>`);
+                $detail('article.post-content img').each((_, el) => {
+                    $detail(el).replaceWith(`<img src=https:${$detail(el).attr('src')}>`);
                 });
                 item.description = $detail('article.post-content').html();
                 return item;

lib/routes/android/platform-tools-releases.ts

@@ -53,8 +53,8 @@ async function handler() {
             const title = item.attr('data-text');
 
             let description = '';
-            item.nextUntil('h4').each(function () {
-                description += $(this).html();
+            item.nextUntil('h4').each((_, el) => {
+                description += $(el).html();
             });
 
             return {

lib/routes/aqara/post.tsx

@@ -52,13 +52,13 @@ async function handler(ctx) {
 
         // To handle lazy-loaded images.
 
-        content('figure').each(function () {
-            const image = content(this).find('img');
+        content('figure').each((_, el) => {
+            const image = content(el).find('img');
             const src = (image.prop('data-actualsrc') ?? image.prop('data-original') ?? image.prop('src')).replace(/(-\d+x\d+)/, '');
             const width = image.prop('data-rawwidth') ?? image.prop('width');
             const height = image.prop('data-rawheight') ?? image.prop('height');
 
-            content(this).replaceWith(
+            content(el).replaceWith(
                 renderToString(
                     <figure>
                         <img src={src} width={width} height={height} />