Skip to content

Conversation

@DSdivyanksingh
Copy link
Owner

No description provided.



<!--nav-bar_start-->
<nav class="nav">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They asked Nav Tag inside header tag



<!-- left-section_start_unorderd-list -->
<section class="left_section">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They asked to use Aside Tag for Left Side bar



<!-- mid-section-start-img -->
<section class="mid_section">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They asked to use ID Attribute to this Section tag



<!-- right-section_start-unorderd-list -->
<section class="right_section">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They asked to use Aside tag and ID attribute to this Right side bar



<!-- footer_start-->
<footer class="footer">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They asked to use ID Attribute to this footer tag

margin-top: 3px;
background-color: rgb(36, 35, 35);
}
.nav_link{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nav links should be center aligned

@saikiransathpadi
Copy link

Layout is correct, have a check on using the colors for a better ux.
content getting distortec by changing the
avoid using base 64 urls, its not a good practice
also its a good practice to have alt text for img tags. everything else is nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants