Code Optimization and Security issue fixed #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dagic-zewdu
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Hi @sentayhu19 ,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Suggested changes
Check the comments under the review.
lib/index.js
Outdated
| exports.generate = generate; | ||
| var compute = function (type, optlen, length) { | ||
| var res = ""; | ||
| console.log("COMPUTE RUNNNNNNING.....................", length, "TYPE", optlen); |
There was a problem hiding this comment.
- please remove this
console.logit shows unnecessary messages while using the package
sentayhu19
changed the title
Dagic-zewdu
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Hi @sentayhu19 ,
STATUS: APPROVED ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Math.random()fixed by utilizing therandomBytescomputefunction to execute the generation of the random string foralphanumeric,range,hex,alphabet, andalphanumericgivenoption length,characters, and length` in the asset.