[dev_qorh] WEEK1 solutions #2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuuuuuuYu
reviewed
Nov 13, 2025
| } | ||
|
|
||
| return f(0); | ||
| } |
YuuuuuuYu
reviewed
Nov 13, 2025
two-sum/dev_qorh.ts
Outdated
Comment on lines
5
to
17
| let temp_i = 0; | ||
| let temp_j = 0; | ||
|
|
||
| for (let i = 0; i < nums.length; i++) { | ||
| temp_i = nums[i]; | ||
| for (let j = i + 1; j < nums.length; j++) { | ||
| temp_j = nums[j]; | ||
|
|
||
| if (temp_i + temp_j === target) { | ||
| return [i, j]; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
temp 변수들이 nums[i], nums[j]로 초기화하고 비교만 하는 방식이면
변수 선언 없이 nums만 사용해도 좋을 것 같습니다.
for (let i = 0; i < nums.length; i++) {
for (let j = i + 1; j < nums.length; j++) {
if (nums[i] + nums[j] === target) {
return [i, j];
}
}
}
YuuuuuuYu
reviewed
Nov 13, 2025
| } | ||
|
|
||
| return []; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
ci 를 정상통과 하는 것으로 보아, 적용이 되어 있는 것 같습니다. 확인 감사합니다!
YuuuuuuYu
reviewed
Nov 14, 2025
Comment on lines
+54
to
+69
| function f(num: number) { | ||
| if (resultMap.has(num)) { | ||
| return resultMap.get(num); | ||
| } | ||
|
|
||
| if (nums.length - 1 < num) { | ||
| resultMap.set(num, 0); | ||
| } else { | ||
| const first = nums[num] + f(num + 2); | ||
| const second = f(num + 1); | ||
|
|
||
| const result = first >= second ? first : second; | ||
| resultMap.set(num, result); | ||
| } | ||
|
|
||
| return resultMap.get(num); |
Contributor
There was a problem hiding this comment.
제가 파이썬은 잘 모르지만 num 값이 원소보다는 인덱스 용도로 쓰이는거 같은데 맞을까요?
만약 맞다면 직관적인 변수명(index 등)이 좋을 것 같습니다
YuuuuuuYu
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!