Special case Sphinx-style titles for FinalPeriodFormatter
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
commented
Feb 9, 2022
Merged
DanielNoord
commented
Feb 10, 2022
Pull Request Test Coverage Report for Build 1822739536
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Feb 10, 2022
Collaborator
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Looks good, although I don't use this kind of formatting so I might be missing something. Should we ping the original reporter ?
Owner
Author
|
Original reporter "hearted" the opening post so I think they are aware of this PR. Note that this doesn't really change anything, it's just a failsafe + tests in case of any future changes. The real necessary changes for #36 still need to be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #36.
This already works with the current code, but now when we change anything in
FinalPeriodFormatterwe make sure that this keeps working.Second step would be to recognise Sphinx-style titles in
BeginningQuotesFormatter.