- Improve rush list repo/package detection

Author: DannyBen

rush

@@ -1101,19 +1101,25 @@ list_show_repo() {
   local simple="$2"
   local all="$3"
   local repo="$repo_or_package"
+  local explicit_repo=
   local package glob repo_path infofile regex package_name
 
   if [[ $repo_or_package =~ (.*):(.*) ]]; then
+    explicit_repo=1
     repo=${BASH_REMATCH[1]}
     package=${BASH_REMATCH[2]}
   fi
 
   repo_path=$(config_get "$repo")
 
   if [[ ! $repo_path ]]; then
-    package="$repo"
-    repo="default"
-    repo_path=$(config_get "$repo")
+    if [[ $explicit_repo ]]; then
+      abort "repo not found: $repo"
+    else
+      package="$repo"
+      repo="default"
+      repo_path=$(config_get "$repo")
+    fi
   fi
 
   if [[ $package ]]; then

src/lib/list_show_repo.sh

@@ -3,19 +3,25 @@ list_show_repo() {
   local simple="$2"
   local all="$3"
   local repo="$repo_or_package"
+  local explicit_repo=
   local package glob repo_path infofile regex package_name
 
   if [[ $repo_or_package =~ (.*):(.*) ]]; then
+    explicit_repo=1
     repo=${BASH_REMATCH[1]}
     package=${BASH_REMATCH[2]}
   fi
 
   repo_path=$(config_get "$repo")
 
   if [[ ! $repo_path ]]; then
-    package="$repo"
-    repo="default"
-    repo_path=$(config_get "$repo")
+    if [[ $explicit_repo ]]; then
+      abort "repo not found: $repo"
+    else
+      package="$repo"
+      repo="default"
+      repo_path=$(config_get "$repo")
+    fi
   fi
 
   if [[ $package ]]; then

test/approvals/rush_list_nope_thing

@@ -0,0 +1 @@
+repo not found: nope

test/approvals/rush_list_sample_asd

@@ -0,0 +1 @@
+nothing in sample repo

test/approve

@@ -124,7 +124,10 @@ describe "list"
   approve "rush list --all"
   approve "rush list --all --simple"
   approve "rush list hello"
+  approve "rush list nope:thing" || return 0
+  expect_exit_code 1
   approve "rush list sample"
+  approve "rush list sample:asd"
   approve "rush list nested"
   approve "rush list sample:nested"
   approve "rush list no-such-package"
@@ -166,4 +169,3 @@ describe "copy"
 describe "completions"
   approve "rush completions"
   approve "rush completions -h"
-