Fix NPE when serializing an EffectInstance with no hidden effects.

Darkhax · Darkhax · commit 327057308673 · 2022-06-06T13:11:37.000-06:00
diff --git a/Common/src/main/java/net/darkhax/bookshelf/api/serialization/SerializerEffectInstance.java b/Common/src/main/java/net/darkhax/bookshelf/api/serialization/SerializerEffectInstance.java
@@ -89,7 +89,7 @@ public void toByteBuf(FriendlyByteBuf buffer, MobEffectInstance toWrite) {
         Serializers.BOOLEAN.toByteBuf(buffer, toWrite.isAmbient());
         Serializers.BOOLEAN.toByteBuf(buffer, toWrite.isVisible());
         Serializers.BOOLEAN.toByteBuf(buffer, toWrite.showIcon());
-        Serializers.EFFECT_INSTANCE.toByteBufOptional(buffer, Optional.of(((AccessorMobEffectInstance) toWrite).bookshelf$getHiddenEffect()));
+        Serializers.EFFECT_INSTANCE.toByteBufOptional(buffer, Optional.ofNullable(((AccessorMobEffectInstance) toWrite).bookshelf$getHiddenEffect()));
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public void toByteBuf(FriendlyByteBuf buffer, MobEffectInstance toWrite) {`
`89`	`89`	`Serializers.BOOLEAN.toByteBuf(buffer, toWrite.isAmbient());`
`90`	`90`	`Serializers.BOOLEAN.toByteBuf(buffer, toWrite.isVisible());`
`91`	`91`	`Serializers.BOOLEAN.toByteBuf(buffer, toWrite.showIcon());`
`92`		`- Serializers.EFFECT_INSTANCE.toByteBufOptional(buffer, Optional.of(((AccessorMobEffectInstance) toWrite).bookshelf$getHiddenEffect()));`
	`92`	`+ Serializers.EFFECT_INSTANCE.toByteBufOptional(buffer, Optional.ofNullable(((AccessorMobEffectInstance) toWrite).bookshelf$getHiddenEffect()));`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`@Override`