refactor: "Run all" doesnt expand show results in card models#630
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds state-driven auto-expansion for model run results so live metrics are shown when training is started from a run card.
Changes:
- Adds
autoExpandstate inRunCardand passes it toRunResults. - Updates
RunResultsto expand only when a run is running andautoExpandis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
DashAI/front/src/components/models/RunCard.jsx |
Tracks whether a run-card-initiated training action should auto-expand results. |
DashAI/front/src/components/models/RunResults.jsx |
Uses the new autoExpand prop to decide whether to open the results panel on running status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristian-tamblay
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience in the model training workflow by automatically expanding the results panel when a run is started. The main changes involve adding an
autoExpandstate to control the expansion behavior and ensuring that the results panel only auto-expands when appropriate.User Interface Improvements:
autoExpandstate inRunCard.jsxto track whether the results panel should auto-expand. This state is set totruewhen the user initiates training and reset tofalsewhen the run is not in a running state. [1] [2] [3]autoExpandprop fromRunCard.jsxtoRunResults.jsxto control the expansion of the results panel. [1] [2] [3]Results Panel Behavior:
RunResults.jsxso that the results panel only auto-expands when a run starts andautoExpandistrue, preventing unwanted expansions in other scenarios.These changes make the UI more responsive and intuitive by automatically showing live metrics when a training run is started.