Add delete confirmation modal to ModelComparisonTable and RunCard com…#633
Merged
Merged
Conversation
cristian-tamblay
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add delete confirmation modals to prevent accidental deletion of model runs. Users must now explicitly confirm before deleting a run from both the ModelComparisonTable and the RunCard components. This improves user experience by preventing data loss from unintended clicks.
Type of Change
Changes (by file)
DashAI/front/src/components/models/ModelComparisonTable.jsx: Added delete confirmation modal before removing a run. IntroducedrunToDeletestate to manage confirmation dialog state, and integrated theDeleteConfirmationModalcomponent with proper callbacks.DashAI/front/src/components/models/RunCard.jsx: Added delete confirmation modal to the run card delete button. IntroduceddeleteConfirmOpenstate to control the modal visibility and wrapped the actual delete operation within the confirmation flow.Testing (optional)
Notes (optional)
Uses the existing
DeleteConfirmationModalcomponent from the shared layout components. The translation keymodels:message.confirmDeleteRunis used for the confirmation message. This pattern is consistent with other deletion confirmations in the application.