Skip to content

Add delete confirmation modal to ModelComparisonTable and RunCard com…#633

Merged
cristian-tamblay merged 3 commits into
developfrom
fix/delete-run-confirmation-modal
May 26, 2026
Merged

Add delete confirmation modal to ModelComparisonTable and RunCard com…#633
cristian-tamblay merged 3 commits into
developfrom
fix/delete-run-confirmation-modal

Conversation

@Creylay

@Creylay Creylay commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add delete confirmation modals to prevent accidental deletion of model runs. Users must now explicitly confirm before deleting a run from both the ModelComparisonTable and the RunCard components. This improves user experience by preventing data loss from unintended clicks.


Type of Change

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

  • DashAI/front/src/components/models/ModelComparisonTable.jsx: Added delete confirmation modal before removing a run. Introduced runToDelete state to manage confirmation dialog state, and integrated the DeleteConfirmationModal component with proper callbacks.

  • DashAI/front/src/components/models/RunCard.jsx: Added delete confirmation modal to the run card delete button. Introduced deleteConfirmOpen state to control the modal visibility and wrapped the actual delete operation within the confirmation flow.


Testing (optional)

  • Verify that clicking the delete button on a run card shows a confirmation modal
  • Verify that clicking delete in the ModelComparisonTable also shows a confirmation modal
  • Confirm that the run is only deleted after explicitly confirming in the modal
  • Test that canceling the modal does not delete the run

Notes (optional)

Uses the existing DeleteConfirmationModal component from the shared layout components. The translation key models:message.confirmDeleteRun is used for the confirmation message. This pattern is consistent with other deletion confirmations in the application.

@cristian-tamblay cristian-tamblay added the conflict This PR has merge conflicts label May 26, 2026
@Creylay Creylay removed the conflict This PR has merge conflicts label May 26, 2026
@cristian-tamblay cristian-tamblay merged commit 38cdeed into develop May 26, 2026
19 checks passed
@cristian-tamblay cristian-tamblay deleted the fix/delete-run-confirmation-modal branch May 26, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants