chore: update findable-ui to latest v38.0.0 (#4528) #4532
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UI dependency, refactors how summary data is mapped, and enhances entity configurations with new UI options and slot replacements.
- Refactored summary logic by removing the old
Summariescomponent and introducingmapSummarywith updated view builders. - Upgraded
@databiosphere/findable-uito v38.x and added@tanstack/react-virtualto ESM packages. - Added
uiflags (enableTabs,enableExportButton,enableSummary) and replaced hero/list components with slot-based APIs across multiple entity configs.
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| site-config/**/index/summaryViewModelBuilder.ts | Replaced getSummaries → mapSummary, removed React/Summaries references, updated return type. |
| app/components/Index/common/indexTransformer.ts | Renamed getSummaries → mapSummary, changed return from object[] to [string, string][]. |
| site-config/**/index/*EntityConfig.ts | Added ui sections with enableTabs, enableExportButton, enableSummary, and slot props. |
| package.json | Bumped @databiosphere/findable-ui to ^38.1.0, added @tanstack/react-virtual. |
| next.config.mjs | Included @tanstack/react-virtual in ESM_PACKAGES. |
Comments suppressed due to low confidence (1)
package.json:35
- The PR title and description refer to upgrading to v38.0.0, but
package.jsonuses^38.1.0. Consider aligning the documented target version and the actual dependency spec to avoid confusion.
"@databiosphere/findable-ui": "^38.1.0",
|
|
||
| // Get each summary span's inner text. | ||
| const innerTexts = await summaryLocator | ||
| .locator(MUI_CLASSES.TYPOGRAPHY) // Retrieves the count and label and omits the dot separator. |
There was a problem hiding this comment.
[nitpick] Relying on the generic .MuiTypography-root selector can make tests brittle if other typography elements are added. Consider adding or using a dedicated data-testid on the summary items to target them more reliably.
| .locator(MUI_CLASSES.TYPOGRAPHY) // Retrieves the count and label and omits the dot separator. | |
| .getByTestId(TEST_IDS.SUMMARY_ITEM) // Retrieves the count and label and omits the dot separator. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Leaving it as, for now.
2 participants
Ticket
Closes #4528.
Reviewers
@NoopDog.
This pull request introduces a series of updates to improve the functionality, readability, and maintainability of the codebase, particularly focusing on the data export workflow, entity configurations, and dependencies. The most significant changes include refactoring entity configurations for better UI support, updating test cases to enhance clarity and reliability, and upgrading dependencies for improved performance and compatibility.
Refactoring and UI Enhancements:
activitiesEntityConfig.ts,biosamplesEntityConfig.ts,datasetsEntityConfig.ts,donorsEntityConfig.ts,filesEntityConfig.ts) to replacelistViewwithuiconfigurations that include support for tabs, export buttons, and summary features. This change improves modularity and enables more consistent UI behavior. [1] [2] [3] [4] [5]ui: { enableTabs: true }. [1] [2] [3]Test Case Improvements:
testIndexExportSummaryfunction with a more detailed and robust test implementation inanvil-index-export-button.spec.ts. The new test verifies that summary labels and counts match between the index and export pages, improving test reliability and clarity. [1] [2]urlOrPredicate,waitForTestId) to streamline test logic and provide better abstraction for common operations.Dependency Updates:
@databiosphere/findable-uito version^38.1.0and added@tanstack/react-virtualas a new dependency to enhance virtualized rendering capabilities. [1] [2]next.config.mjsto include@tanstack/react-virtual.Code Cleanup:
getSummariesfunction withmapSummaryinindexTransformer.tsto return key-value pairs instead of objects, improving data structure consistency.Miscellaneous Updates:
explorerTitlefrom configuration files where it was no longer needed, aligning with the updated UI design. [1] [2]anvil-cmg/dev/config.tsto usebuildSummariesfor mapping API responses, enhancing modularity.