Skip to content

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Jul 24, 2025

Ticket

Closes #4538.

Reviewers

@NoopDog.

This pull request introduces updates to the dataDictionaryMapper functionality and upgrades several dependencies in the project. The key changes include refactoring the column definitions for better compatibility with the @tanstack/react-table library, adding new table options, and upgrading multiple dependencies in package.json.

Refactoring in dataDictionaryMapper:

  • Updated COLUMN_DEFS in constants.ts to use accessorKey instead of accessorFn for the "description" column, and modified the cell property to cast cellContext explicitly for compatibility with MarkdownCell. [1] [2]
  • Added new table options in tableOptions.ts, including enableExpanding, getRowCanExpand, and getRowId, while removing the expanded property from the initial state.

Dependency Upgrades:

  • Upgraded @databiosphere/findable-ui to version ^40.0.0 for improved UI components.
  • Updated @next/mdx, next, @next/eslint-plugin-next, and eslint-config-next to version ^14.2.30 for compatibility with the latest features and fixes. [1] [2] [3]

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the findable-ui library to version 40.0.0 and makes necessary compatibility changes for the data dictionary mapper functionality.

  • Updates @databiosphere/findable-ui from v38.1.1 to v40.0.0
  • Refactors table column definitions to be compatible with the updated library
  • Updates Next.js and related dependencies to v14.2.30

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updates findable-ui to v40.0.0 and Next.js dependencies to v14.2.30
tableOptions.ts Adds new table configuration options and removes deprecated expanded state
constants.ts Refactors column definition to use accessorKey and explicit type casting

Comment on lines +25 to +26
cell: (cellContext) =>
MarkdownCell(cellContext as CellContext<Attribute, string>),
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type casting to CellContext<Attribute, string> may be unsafe. Consider validating that the cellContext actually contains string data or handling the case where description might be undefined/null before passing to MarkdownCell.

Suggested change
cell: (cellContext) =>
MarkdownCell(cellContext as CellContext<Attribute, string>),
cell: (cellContext) => {
const value = cellContext.getValue();
const safeValue = typeof value === "string" ? value : "";
return MarkdownCell({ ...cellContext, getValue: () => safeValue });
},

Copilot uses AI. Check for mistakes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as is... Need to resolve type casting in findable-ui.

@frano-m frano-m marked this pull request as ready for review July 24, 2025 09:10
@NoopDog NoopDog merged commit 58ac415 into main Jul 24, 2025
4 checks passed
@frano-m frano-m deleted the fran/4538-findable branch August 19, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HCA DX] Update findable-ui to latest version v40.0.0

2 participants