Ansible 2.8 error

[naxhh]

hi! when testing the callback against ansible 2.8 I face this error

Traceback (most recent call last):
  File "/usr/local/bin/ansible-playbook", line 110, in <module>
    exit_code = cli.run()
  File "/usr/local/lib/python2.7/site-packages/ansible/cli/playbook.py", line 123, in run
    results = pbex.run()
  File "/usr/local/lib/python2.7/site-packages/ansible/executor/playbook_executor.py", line 100, in run
    self._tqm.load_callbacks()
  File "/usr/local/lib/python2.7/site-packages/ansible/executor/task_queue_manager.py", line 162, in load_callbacks
    callback_obj = callback_plugin()
  File "/Users/ignacio.tolstoy/code/devops-mt--ansible/callback_plugins/datadog_callback.py", line 40, in __init__
    self._options = cli.options
AttributeError: 'PlaybookCLI' object has no attribute 'options'

Not related, what is the standard way to run the callback only when a env var is present?
For example, we have 3-4 playbooks but only want to run the callback in one of them.
Since all of them share the config they run the callback by default

[naxhh]

This seems to be related with this PR and the fact that this callback imports cli to retrieve the inventory name.

[naxhh]

In our case we workarounded this with:

- if cli:
+ if cli and hasattr(cli, 'options'):

[KoenDG]

Also having this problem with Ansible 2.8 and python3, workaround is not working, breaks on line 274:

ansible-datadog-callback/datadog_callback.py

Line 274 in 596dc0d

self._inventory_name),

With this error:

ERROR! Unexpected Exception, this is probably a bug: expected string or bytes-like object

[naxhh]

You should also default the inventory name to something. In our case we don't care about events so we just use 'default'

[rsdcobalt]

submitted this PR to check if using ansible 2.8 and do stuff accordingly: #47

[aairey]

Using the latest from master gets rid of this error.

But I am still getting errors sending metrics and events, even though everything is set up (api_key set in datadog_callback.yml as before):

Couldn't send metric "elapsed_time" to Datadog
API key is not set. Please run 'initialize' method first.

[fh-jinoa]

Anyone know the status of this? I am still getting:
ERROR! Unexpected Exception, this is probably a bug: 'PlaybookCLI' object has no attribute 'options'

[fh-jinoa]

looks like it was fixed. Can we close this since its misleading?

[aairey]

I also got it to work, so no issue anymore for me at least.

…

On Wed, 2 Oct 2019, 21:43 iknowajosh, ***@***.***> wrote: looks like it was fixed. Can we close this since its misleading? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#46?email_source=notifications&email_token=AB2KHPXBZ6HQUDST56GGCTTQMT2URA5CNFSM4HNUBEU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAF545I#issuecomment-537648757>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB2KHPUM3BORRXKTITYI55TQMT2URANCNFSM4HNUBEUQ> .

[svpernova09]

This also works for Ansible 2.9.6. Thanks!