cast api_key as str in datadog.initialize #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a vaulted variable the API key is returned with the type: ansible.parsing.yaml.objects.AnsibleVaultEncryptedUnicode (ref), where as datadogpy expects the type: String (ref). The result is that the API fails to parse the Ansible type and the following (403) error is returned by API:
While the
AnsibleVaultEncryptedUnicodecan not be a considered a String most common python string actions will now work as expected (ref). Casting the API key to a String before it is used to initialise datadogpy seems to resolve the issue where the API returns 403.=> Relevant test on Ansible Repo:
https://github.com/ansible/ansible/blob/4856ab0e681f799ed4f893a34deb6a50e6d2400e/test/units/config/test_manager.py#L147-L157