Skip to content

Provide better message on import errors to ease debugging #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Provide better message on import errors to ease debugging #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions datadog_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,35 @@
import os
import time

IMPORT_ERROR = None
try:
import datadog
import yaml
from packaging import version
HAS_MODULES = True
except ImportError:
HAS_MODULES = False
except ImportError as e:
IMPORT_ERROR = str(e)


import ansible
from ansible.plugins.callback import CallbackBase
from __main__ import cli

ANSIBLE_ABOVE_28 = False
if HAS_MODULES and version.parse(ansible.__version__) >= version.parse('2.8.0'):
if IMPORT_ERROR is None and version.parse(ansible.__version__) >= version.parse('2.8.0'):
ANSIBLE_ABOVE_28 = True
from ansible.context import CLIARGS

DEFAULT_DD_URL = "https://api.datadoghq.com"

class CallbackModule(CallbackBase):
def __init__(self):
if not HAS_MODULES:
if IMPORT_ERROR is not None:
self.disabled = True
print('Datadog callback disabled: missing "datadog", "yaml", and/or "packaging" python package.')
print(
'Datadog callback disabled because of a dependency problem: {}. '
'Please install requirements with "pip install -r requirements.txt"'
.format(IMPORT_ERROR)
)
else:
self.disabled = False
# Set logger level - datadog api and urllib3
Expand All @@ -39,7 +43,7 @@ def __init__(self):
self._playbook_name = None
self._start_time = time.time()
self._options = None
if HAS_MODULES and cli:
if IMPORT_ERROR is None and cli:
if ANSIBLE_ABOVE_28:
self._options = CLIARGS
else:
Expand Down