Skip to content

Update source for reporting module_name #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Update source for reporting module_name #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions datadog_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

DEFAULT_DD_URL = "https://api.datadoghq.com"


class CallbackModule(CallbackBase):
def __init__(self):
if IMPORT_ERROR is not None:
Expand Down Expand Up @@ -175,24 +176,24 @@ def pluralize(number, noun):

# format helper for event_text
@staticmethod
def format_result(res):
def format_result(result):
res = result._result
module_name = result._task.action
msg = "$$$\n{0}\n$$$\n".format(res['msg']) if res.get('msg') else ""
module_name = 'undefined'

if res.get('censored'):
event_text = res.get('censored')
elif not res.get('invocation'):
event_text = msg
else:
invocation = res['invocation']
module_name = invocation.get('module_name', 'undefined')
event_text = "$$$\n{0}[{1}]\n$$$\n".format(module_name, invocation.get('module_args', ''))
event_text += msg
if 'module_stdout' in res:
if 'stdout' in res:
# On Ansible v2, details on internal failures of modules are not reported in the `msg`,
# so we have to extract the info differently
event_text += "$$$\n{0}\n{1}\n$$$\n".format(
res.get('module_stdout', ''), res.get('module_stderr', ''))
res.get('stdout', ''), res.get('stderr', ''))

module_name_tag = 'module:{0}'.format(module_name)

Expand All @@ -207,13 +208,13 @@ def get_dd_hostname(self, ansible_hostname):
return dd_hostname

### Ansible callbacks ###
def runner_on_failed(self, host, res, ignore_errors=False):
host = self.get_dd_hostname(host)
def v2_runner_on_failed(self, result, ignore_errors=False):
host = self.get_dd_hostname(result._host.get_name())
# don't post anything if user asked to ignore errors
if ignore_errors:
return

event_text, module_name_tag = self.format_result(res)
event_text, module_name_tag = self.format_result(result)
self.send_task_event(
'Ansible task failed on "{0}"'.format(host),
alert_type='error',
Expand All @@ -222,11 +223,11 @@ def runner_on_failed(self, host, res, ignore_errors=False):
host=host,
)

def runner_on_ok(self, host, res):
host = self.get_dd_hostname(host)
def v2_runner_on_ok(self, result):
host = self.get_dd_hostname(result._host.get_name())
# Only send an event when the task has changed on the host
if res.get('changed'):
event_text, module_name_tag = self.format_result(res)
if result._result.get('changed'):
event_text, module_name_tag = self.format_result(result)
self.send_task_event(
'Ansible task changed on "{0}"'.format(host),
alert_type='success',
Expand All @@ -235,8 +236,9 @@ def runner_on_ok(self, host, res):
host=host,
)

def runner_on_unreachable(self, host, res):
host = self.get_dd_hostname(host)
def v2_runner_on_unreachable(self, result):
res = result._result
host = self.get_dd_hostname(result._host.get_name())
event_text = "\n$$$\n{0}\n$$$\n".format(res)
self.send_task_event(
'Ansible failed on unreachable host "{0}"'.format(host),
Expand Down