add support for configuring trace agent #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 5.11.0, there are additional sections in datadog.conf observed by the trace agent. But changing the semantics of `datadog_config` will break backwards compatibility with existing role users expecting that dictionary to populate the [Main] section. Instead, we add another nested dictionary to support extra sections.
irabinovitch
requested review from
olivielpeau,
talwai and
yannmh
and removed request for
yannmh
olivielpeau
approved these changes
Mar 1, 2017
README.md
Outdated
| trace.config: | ||
| env: dev | ||
| trace.concentrator: | ||
| extra_aggregators: version |
Member
There was a problem hiding this comment.
nit: an extra leading whitespace would be nice to keep the 2-space indentation
a wild tab appeared, replaced with spaces
talwai
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 5.11.0, there are additional sections in datadog.conf observed
by the trace agent.
But changing the semantics of
datadog_configwill break backwardscompatibility with existing role users expecting that dictionary
to populate the [Main] section.
Instead, we add another nested dictionary to support extra
sections.