Pipe datadog_checks through list for Python 3 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into [an issue described in Ansible on Python 3](ansible/ansible#19514), in which the module fails when trying to iterate through keys: ``` TASK [Datadog.datadog : Create a configuration file for each Datadog check] **** failed: [default] (item=dict_keys(['process'])) => {"failed": true, "item": "dict_keys(['process'])", "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute \"dict_keys(['process'])\""} PLAY RECAP ********************************************************************* default : ok=8 changed=6 unreachable=0 failed=1 ``` Ansible developers recommend piping dicts through `list` to work around this issue. Trying this on my own Ansible 2.2.1.0/Python 3 environment, I was able to eliminate the issue. The discussion on the issue indicates that this is backward-compatible with lesser versions of Ansible and Python.
Mattlk13
approved these changes
Mar 22, 2017
olivielpeau
approved these changes
Mar 31, 2017
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Looks good, thanks @gtrummell! (and thanks for the detailed description)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue described in Ansible on Python 3, in which the module fails when trying to iterate through keys:
Ansible developers recommend piping dicts through
listto work around this issue. Trying this on my own Ansible 2.2.1.0/Python 3 environment, I was able to eliminate the issue. The discussion on the issue indicates that this is backward-compatible with lesser versions of Ansible and Python.