Skip to content

Security Monitoring - Fix payload of Validation Endpoint for Suppressions #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Security Monitoring - Fix payload of Validation Endpoint for Suppressions #3112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64883,7 +64883,7 @@ paths:
content:
application/json:
schema:
$ref: '#/components/schemas/SecurityMonitoringSuppressionUpdateRequest'
$ref: '#/components/schemas/SecurityMonitoringSuppressionCreateRequest'
required: true
responses:
'204':
Expand Down
14 changes: 7 additions & 7 deletions examples/v2/security-monitoring/ValidateSecurityMonitoringSuppression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
import com.datadog.api.client.ApiClient;
import com.datadog.api.client.ApiException;
import com.datadog.api.client.v2.api.SecurityMonitoringApi;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionCreateAttributes;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionCreateData;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionCreateRequest;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionType;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionUpdateAttributes;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionUpdateData;
import com.datadog.api.client.v2.model.SecurityMonitoringSuppressionUpdateRequest;

public class Example {
public static void main(String[] args) {
ApiClient defaultClient = ApiClient.getDefaultApiClient();
SecurityMonitoringApi apiInstance = new SecurityMonitoringApi(defaultClient);

SecurityMonitoringSuppressionUpdateRequest body =
new SecurityMonitoringSuppressionUpdateRequest()
SecurityMonitoringSuppressionCreateRequest body =
new SecurityMonitoringSuppressionCreateRequest()
.data(
new SecurityMonitoringSuppressionUpdateData()
new SecurityMonitoringSuppressionCreateData()
.attributes(
new SecurityMonitoringSuppressionUpdateAttributes()
new SecurityMonitoringSuppressionCreateAttributes()
.dataExclusionQuery("source:cloudtrail account_id:12345")
.description(
"This rule suppresses low-severity signals in staging"
Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/datadog/api/client/v2/api/SecurityMonitoringApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12179,7 +12179,7 @@ public CompletableFuture<ApiResponse<Void>> validateSecurityMonitoringRuleWithHt
* @param body (required)
* @throws ApiException if fails to make API call
*/
public void validateSecurityMonitoringSuppression(SecurityMonitoringSuppressionUpdateRequest body)
public void validateSecurityMonitoringSuppression(SecurityMonitoringSuppressionCreateRequest body)
throws ApiException {
validateSecurityMonitoringSuppressionWithHttpInfo(body);
}
Expand All @@ -12193,7 +12193,7 @@ public void validateSecurityMonitoringSuppression(SecurityMonitoringSuppressionU
* @return CompletableFuture
*/
public CompletableFuture<Void> validateSecurityMonitoringSuppressionAsync(
SecurityMonitoringSuppressionUpdateRequest body) {
SecurityMonitoringSuppressionCreateRequest body) {
return validateSecurityMonitoringSuppressionWithHttpInfoAsync(body)
.thenApply(
response -> {
Expand All @@ -12218,7 +12218,7 @@ public CompletableFuture<Void> validateSecurityMonitoringSuppressionAsync(
* </table>
*/
public ApiResponse<Void> validateSecurityMonitoringSuppressionWithHttpInfo(
SecurityMonitoringSuppressionUpdateRequest body) throws ApiException {
SecurityMonitoringSuppressionCreateRequest body) throws ApiException {
Object localVarPostBody = body;

// verify the required parameter 'body' is set
Expand Down Expand Up @@ -12263,7 +12263,7 @@ public ApiResponse<Void> validateSecurityMonitoringSuppressionWithHttpInfo(
*/
public CompletableFuture<ApiResponse<Void>>
validateSecurityMonitoringSuppressionWithHttpInfoAsync(
SecurityMonitoringSuppressionUpdateRequest body) {
SecurityMonitoringSuppressionCreateRequest body) {
Object localVarPostBody = body;

// verify the required parameter 'body' is set
Expand Down
2 changes: 1 addition & 1 deletion ...ces/cassettes/features/v2/Validate_a_suppression_rule_returns_Bad_Request_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-09-01T21:36:42.334Z
2025-09-04T08:33:38.344Z
6 changes: 3 additions & 3 deletions ...urces/cassettes/features/v2/Validate_a_suppression_rule_returns_Bad_Request_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"httpRequest": {
"body": {
"type": "JSON",
"json": "{\"data\":{\"attributes\":{\"data_exclusion_query\":\"not enough attributes\"},\"type\":\"suppressions\"}}"
"json": "{\"data\":{\"attributes\":{\"data_exclusion_query\":\"not enough attributes\",\"enabled\":false,\"name\":\"cold_harbour\",\"rule_query\":\"rule:[A-Invalid\"},\"type\":\"suppressions\"}}"
},
"headers": {},
"method": "POST",
Expand All @@ -12,7 +12,7 @@
"secure": true
},
"httpResponse": {
"body": "{\"errors\":[\"input_validation_error(Field 'data.attributes.rule_query' is invalid: field 'rule_query' is required)\",\"input_validation_error(Field 'data.attributes.name' is invalid: name cannot be empty)\"]}",
"body": "{\"errors\":[\"input_validation_error(Field 'data.attributes.rule_query' is invalid: rule query is invalid)\"]}",
"headers": {
"Content-Type": [
"application/json"
Expand All @@ -27,6 +27,6 @@
"timeToLive": {
"unlimited": true
},
"id": "703e6a45-408a-1cf4-017d-6f3d7e7b26c9"
"id": "075f4d7d-8168-bd20-ff83-cef03495b3c5"
}
]
2 changes: 1 addition & 1 deletion src/test/resources/com/datadog/api/client/v2/api/security_monitoring.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ Feature: Security Monitoring
@team:DataDog/k9-cloud-security-platform
Scenario: Validate a suppression rule returns "Bad Request" response
Given new "ValidateSecurityMonitoringSuppression" request
And body with value {"data": {"attributes": {"data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
And body with value {"data": {"attributes": {"name" : "cold_harbour", "enabled": false, "rule_query":"rule:[A-Invalid", "data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
When the request is sent
Then the response status is 400 Bad Request

Expand Down
Loading