Add retry support #1502
Merged
Add retry support #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therve
requested changes
Aug 22, 2023
…-api-client-ruby into hzhang/add-retry-support
…-api-client-ruby into hzhang/add-retry-support
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
* Base design * add_test * adjust test * handle nil * Fix tests * add testing sleep time without actually sleeping * Add documentation * change code generator * pre-commit fixes * change how configs are made * pre-commit fixes * update readme doc * pre-commit fixes * adds validation for backoff_base * pre-commit fixes * change generator * pre-commit fixes * add validation back * pre-commit fixes --------- Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 0af80ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds option to enable retry so that when a response code 429 is received the api client would retry
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.