Fix go tests to maintain order of the log output #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
reviewed
Nov 9, 2021
nhinsch
reviewed
Nov 9, 2021
Contributor
|
Looks like the tests are failing in CI (could be related to this PR, might be a pre-existing issue). What is causing those failures and is it possible to fix them in this PR? |
nhinsch
approved these changes
Nov 22, 2021
Contributor
nhinsch
left a comment
nhinsch
left a comment
There was a problem hiding this comment.
Per Slack message, I think this is now in a place where it's ready to be merged (we will then move the tests to the agent repo).
nhinsch
reviewed
Nov 22, 2021
|
|
||
| now=$(date +"%r") | ||
| echo "Sleeping $LOGS_WAIT_SECONDS seconds to wait for logs to appear in CloudWatch..." | ||
| echo "This should be done in 10 minutes from $now" |
Contributor
There was a problem hiding this comment.
This message is a nice touch, I think it improves the user experience of running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the handler contained logs and metrics leading to a single binary, but we did not sort the log output of the integration test. This led to constant changes in the integration test output. Trying to use sort when normalizing the logs resulted in unordered log lines. I went back to a separated metric and log binary which is also in line with the other tests.