Skip to content

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Sep 30, 2025

Right now we have debug log like Flushing traces took 50ms. This PR adds a space between 50 and ms so it's easier to process the log. For example, we can use echo 'Flushing traces took 50 ms' | awk '{print $4}' to extract the 50.

@lym953 lym953 requested a review from a team as a code owner September 30, 2025 18:47
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, worth noting that this is printing wall clock time which may not equal CPU time, and some measurements span async work over multiple invocations

@lym953 lym953 merged commit 62eff7b into main Oct 1, 2025
46 checks passed
@lym953 lym953 deleted the yiming.luo/fmt-duration-log branch October 1, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants