Add python support in integration tests #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhinsch
reviewed
Jun 21, 2021
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| # Todo : retrieve this layer version automatically from AWS | ||
| NODE_LAYER_VERSION: 55 | ||
| PYTHON_LAYER_VERSION: 41 |
Contributor
There was a problem hiding this comment.
Do we still have a plan to automatically retrieve this from AWS?
nhinsch
reviewed
Jun 21, 2021
| ) | ||
|
|
||
| var ( | ||
| extensionName = "recorder-extension" // extension name has to match the filename |
Contributor
There was a problem hiding this comment.
Nit: Any reason this is a var and not a const?
nhinsch
reviewed
Jun 21, 2021
| return &res, nil | ||
| } | ||
|
|
||
| // Start begins running the sidecar |
Contributor
There was a problem hiding this comment.
What is "the sidecar" here?
nhinsch
reviewed
Jun 21, 2021
| fmt.Printf("Error while JSON encoding the Log") | ||
| } | ||
| stringJsonLog := string(jsonLog) | ||
| // if we log an unwanted log, it will be availble in the next log api payload -> infinite loop |
Contributor
There was a problem hiding this comment.
Nit: availble -> available
nhinsch
reviewed
Jun 21, 2021
| http.HandleFunc("/api/v1/check_run", func(w http.ResponseWriter, r *http.Request) { | ||
| }) | ||
|
|
||
| // port 8080 is used by the Lambda Invoke API |
Contributor
There was a problem hiding this comment.
I would move this comment to where you specify the port as 3333.
nhinsch
reviewed
Jun 21, 2021
nhinsch
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.