fix(traces): use channel-based aggregator #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if response_tx.send(batches).is_err() { | ||
| error!("Failed to send trace flush response - receiver dropped"); | ||
| } |
Contributor
There was a problem hiding this comment.
would be great to log the error details.
Contributor
Author
There was a problem hiding this comment.
I think the error here just contains the data that failed to send
Contributor
There was a problem hiding this comment.
I am thinking of sth like below. It will give us more context in case of errors.
if let Err(e) = response_tx.send(batches) {
error!("Failed to send trace flush response : {}", e);
}
Contributor
Author
There was a problem hiding this comment.
I tried this, but here the error is the Vec<Vec<SendDataBuilder>> of data that failed to send and doesn't have additional context I believe
lym953
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a channel-based aggregator for traces to avoid locking on aggregation. Adds an aggregator service which receives incoming commands on a channel. Commands can be to insert payloads, get batches, and shutdown.
Follows a similar pattern as #879. Tested with self-monitoring and tested that dual shipping still works as well.
SVLS-7647