Skip to content

fix: set tmp_free metric #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

fix: set tmp_free metric #937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions bottlecap/src/metrics/enhanced/lambda.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ impl Lambda {
.try_into()
.unwrap_or_default();

// Set all tmp metrics - need tmp_max and tmp_used to calculate tmp_free
if metrics.tmp_used > 0.0 {
let metric = Metric::new(
constants::TMP_USED_METRIC.into(),
Expand All @@ -637,8 +638,32 @@ impl Lambda {
if let Err(e) = aggr_handle.insert_batch(vec![metric]) {
error!("Failed to insert tmp_used metric: {}", e);
}

if let Ok(tmp_max) = statfs::get_tmp_max() {
let metric = Metric::new(
constants::TMP_MAX_METRIC.into(),
MetricValue::distribution(tmp_max),
tags.clone(),
Some(now),
);
if let Err(e) = aggr_handle.insert_batch(vec![metric]) {
error!("Failed to insert tmp_max metric: {}", e);
}

let tmp_free = tmp_max - metrics.tmp_used;
let metric = Metric::new(
constants::TMP_FREE_METRIC.into(),
MetricValue::distribution(tmp_free),
tags.clone(),
Some(now),
);
if let Err(e) = aggr_handle.insert_batch(vec![metric]) {
error!("Failed to insert tmp_free metric: {}", e);
}
}
}

// Set file descriptor use
if metrics.fd_use > 0.0 {
let metric = Metric::new(
constants::FD_USE_METRIC.into(),
Expand All @@ -651,6 +676,7 @@ impl Lambda {
}
}

// Set threads use
if metrics.threads_use > 0.0 {
let metric = Metric::new(
constants::THREADS_USE_METRIC.into(),
Expand All @@ -675,8 +701,6 @@ impl Lambda {
return;
}

let tmp_max = statfs::get_tmp_max().ok();

let pids = proc::get_pid_list();
let fd_max = proc::get_fd_max_data(&pids);
let threads_max = proc::get_threads_max_data(&pids);
Expand All @@ -690,18 +714,6 @@ impl Lambda {

let tags = self.get_dynamic_value_tags();

if let Some(tmp_max) = tmp_max {
let metric = Metric::new(
constants::TMP_MAX_METRIC.into(),
MetricValue::distribution(tmp_max),
tags.clone(),
Some(now),
);
if let Err(e) = self.aggr_handle.insert_batch(vec![metric]) {
error!("Failed to insert tmp_max metric: {}", e);
}
}

let metric = Metric::new(
constants::FD_MAX_METRIC.into(),
MetricValue::distribution(fd_max),
Expand Down
Loading