Run integration tests in GitHub #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Apr 2, 2021
Contributor
DarcyRaynerDD
left a comment
DarcyRaynerDD
left a comment
There was a problem hiding this comment.
LGTM, left one comment
scripts/build_layers.sh
Outdated
| temp_dir=$(mktemp -d) | ||
| docker build -t datadog-lambda-layer-node:$1 . --no-cache \ | ||
| --build-arg image=node:$1-alpine | ||
| --build-arg image=node:$1-alpine --network host |
Contributor
Author
There was a problem hiding this comment.
Good question, I don't know and I'm not sure why this is here, I have no recollection of adding this. I'll remove it from the PR. fwiw it seems to be a feature that is only supported on Linux hosts, not on Docker for Mac anyway.
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 86.53% 86.53%
=======================================
Files 31 31
Lines 1203 1203
Branches 236 236
=======================================
Hits 1041 1041
Misses 106 106
Partials 56 56 Continue to review full report at Codecov.
|
nhinsch
force-pushed
the
ngh/integration-ci
branch
from
08c373f to
318580e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports the recent changes to
datadog-lambda-pythonenabling integration tests to run in GitHub.Motivation
See DataDog/datadog-lambda-python#121 and related pull requests.
Testing Guidelines
The integration tests run and pass in GitHub.
Types of Changes
Check all that apply