Combine integration tests for metrics and tracing #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Speeds up the integration tests running in GitHub from ~14-15 minutes to ~10 minutes.
Previously, metrics and tracing were tested separately in the integration tests. Testing different things separately is normally a good idea, but in this context it adds a lot of time to each integration test run. So, I combined the metrics and tracing code into a single function. This cuts the number of functions to test in half.
Motivation
We want the integration tests to run as fast as possible in CI.
Additional Notes
To further accelerate the integration tests in CI, we should run the tests for the different Python runtimes (e.g. 3.7, 3.8) in parallel. To do this, we should modify our integration tests to be able to run for a single runtime. Unfortunately this will be a non-trivial change because we will also need to re-work our layer publishing and signing scripts to support releasing a layer for a single runtime in the sandbox environment. We can save this work for later.
I did update the
build_layers.shscript to support this, but stopped there. I decided to leave this in place so we can pick this up in the future.Types of Changes
Check all that apply