Skip to content

Conversation

@nhinsch
Copy link
Contributor

@nhinsch nhinsch commented Apr 1, 2021

What does this PR do?

We always want to run sls remove when exiting. As @agocs pointed out, the best way to accomplish this is with trap.

Testing Guidelines

Integration tests pass and the stack is still deleted.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhinsch nhinsch marked this pull request as ready for review April 1, 2021 21:54
@nhinsch nhinsch requested a review from a team as a code owner April 1, 2021 21:54
@nhinsch nhinsch merged commit 339f6ed into main Apr 1, 2021
@nhinsch nhinsch deleted the ngh/trap branch April 1, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants