Add option to fetch API key from AWS SSM #196
Conversation
|
Hi marshall0705 👋 |
|
Hi @DarcyRaynerDD |
| DD_API_KEY = boto3.client("secretsmanager").get_secret_value( | ||
| SecretId=SECRET_ARN | ||
| )["SecretString"] | ||
| elif "DD_API_KEY_SSM_NAME" in os.environ: |
There was a problem hiding this comment.
Could we rename this it DD_SSM_API_KEY, just to keep it consistent with DD_KMS_API_KEY
There was a problem hiding this comment.
@marshall0705, I forgot to submit the review, doh
There was a problem hiding this comment.
I had considered naming it that. It was a choice between the convention used for the secrets manager var, and the convention used for the KMS var.
I chose this name due to DD_KMS_API_KEY and DD_API_KEY both actually containing the key (albeit one of them encrypted), whereas DD_API_KEY_SECRET_ARN is a reference to a remote location, as is DD_API_KEY_SSM_NAME.
If you would still like the name changing, I'm fine to do so.
There was a problem hiding this comment.
That makes sense, I think we can keep your naming convention then. I'll merge this and roll it out into the next release.
2 participants
What does this PR do?
Motivation
I use the parameter store for all other things, I like to be consistent where possible.
Additional Notes
Related issue: #195