Add aws_account tag to enhanced metrics and Lambda logs #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocs
reviewed
Mar 17, 2020
|
|
||
|
|
||
| def parse_lambda_tags_from_arn(arn): | ||
| def parse_lambda_tags_from_arn(arn, aws_account_tag=False): |
There was a problem hiding this comment.
Are you using aws_account_tag for something?
There was a problem hiding this comment.
oops no, I meant to remove that, thanks :)
tianchu
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the aws_account tag to enhanced metrics and Lambda logs to match how we tag CloudWatch aws.lambda metrics.
The logs and metrics are currently being tagged with account_id only, which causes issues when trying to pivot from the graphs at the top of the serverless detail page to the Lambda's logs - because the metrics are tagged with aws_account and the logs are not, the
View related logslink returns no results.Checklist