Skip to content

Terraform installation and permissions #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2020
Merged

Terraform installation and permissions #238

merged 2 commits into from
Mar 27, 2020

Conversation

@tianchu
Copy link
Contributor

@tianchu tianchu commented Mar 27, 2020 •
edited
Loading

What does this PR do?

  • Add terraform sample configuration
  • Add a permissions section to explain the permissions needed to deploy the stack and the IAM roles created by the stack
  • Collapse sections with too many steps and code samples

Checklist

  • Member of the datadog team has run integration tests

pinkerton
pinkerton reviewed Mar 27, 2020
View reviewed changes
pinkerton
pinkerton reviewed Mar 27, 2020
View reviewed changes
pinkerton
pinkerton reviewed Mar 27, 2020
View reviewed changes
pinkerton
pinkerton reviewed Mar 27, 2020
View reviewed changes
pinkerton
pinkerton approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@pinkerton pinkerton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple copy suggestions but looks good!

@tianchu
Apply suggestions from code review
ec3659b 
Co-Authored-By: Stephen Pinkerton <stephen.pinkerton@datadoghq.com>
@tianchu tianchu merged commit f99cb99 into master Mar 27, 2020
@tianchu tianchu deleted the tian.chu/terraform-and-permissions branch March 27, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pinkerton pinkerton pinkerton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tianchu @pinkerton