Skip to content

Fix enhanced metric tag conversion #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2020
Merged

Fix enhanced metric tag conversion #240

merged 6 commits into from
Mar 31, 2020
+92 −24

Conversation

@DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Modify tag parsing rules to match Datadog's internal integrations

  1. Convert camel case to underscores
  2. Replaces colons with _
  3. Convert to all lowercase unicode string
  4. Convert bad characters to underscores
  5. Dedupe contiguous underscores
  6. Remove initial underscores/digits such that the string
  7. Truncate to 200 characters
  8. Strip trailing underscores

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Checklist

  • Member of the datadog team has run integration tests

swfunc
swfunc reviewed Mar 31, 2020
View reviewed changes
@DarcyRaynerDD DarcyRaynerDD merged commit fd72343 into master Mar 31, 2020
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/fix-enhanced-metrics-tags branch March 31, 2020 20:16
@tianchu tianchu mentioned this pull request Apr 16, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@swfunc swfunc swfunc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarcyRaynerDD @swfunc