Skip to content

Conversation

@tianchu
Copy link
Contributor

@tianchu tianchu commented Jun 2, 2020

What does this PR do?

Ensure the forwarder can be installed to US Gov (and China) AWS accounts.

  • Encrypt the s3 bucket temporarily storing forwarder source code
  • Block public access on the s3 bucket temporarily storing forwarder source code
  • Update ARNs to use a wildcard for the AWS partition segment
  • Update service principles with the .cn suffix for China

Motivation

Ensure the forwarder can be installed to US Gov (and China) AWS accounts.

Testing Guidelines

  • No regression to installation in the regular AWS partition
  • Forwarder can be installed in a real US Gov AWS account

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@tianchu tianchu force-pushed the tian.chu/forwarder-us-gov branch from 1224b2d to 39ebeba Compare June 5, 2020 16:08
@tianchu tianchu changed the title Ensure the forwarder can be installed to US Gov AWS accounts Ensure the forwarder can be installed to GovCloud Jun 5, 2020
@tianchu tianchu merged commit 4408b45 into master Jun 5, 2020
@tianchu tianchu deleted the tian.chu/forwarder-us-gov branch June 5, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants