Jordan.storms/add init duration metric and cold_start tags #274
+97
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcstorms1
changed the title
|
Can you add a test case for the new metric and tag https://github.com/DataDog/datadog-serverless-functions/blob/master/aws/logs_monitoring/tests/test_enhanced_lambda_metrics.py? |
tianchu
reviewed
Jun 5, 2020
tianchu
reviewed
Jun 5, 2020
tianchu
approved these changes
Jun 8, 2020
tianchu
reviewed
Jun 8, 2020
Comment on lines
+454
to
+469
| # if cold_start: | ||
| if regex_match.group(INIT_DURATION_METRIC_NAME): | ||
| metric_point_value = float(regex_match.group(INIT_DURATION_METRIC_NAME)) | ||
| # Multiply by 1/1000 to convert ms to seconds | ||
| metric_point_value *= METRIC_ADJUSTMENT_FACTORS[INIT_DURATION_METRIC_NAME] | ||
|
|
||
| initial_duration = DatadogMetricPoint( | ||
| "{}.{}".format( | ||
| ENHANCED_METRICS_NAMESPACE_PREFIX, INIT_DURATION_METRIC_NAME | ||
| ), | ||
| metric_point_value, | ||
| ) | ||
|
|
||
| initial_duration.add_tags(tags) | ||
|
|
||
| metrics.append(initial_duration) |
There was a problem hiding this comment.
@jcstorms1 my apologies, after a weekend, I totally forgot that another suggestion I pointed out last week was merging line 454-469 (after change) to the for loop of line 471 (after change), their logic are 99% same. I suggest adding INIT_DURATION_METRIC_NAME to METRICS_TO_PARSE_FROM_REPORT and add a check within the for loop like this
for metric_name in METRICS_TO_PARSE_FROM_REPORT:
if not regex_match.group(metric_name):
continue
metric_point_value = float(regex_match.group(metric_name))
....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an
init durationenhanced metric for cold startsAdds a
cold_starttag for all metricsMotivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply