Add timed out enhanced lambda metric #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Jun 10, 2020
| @@ -0,0 +1,99 @@ | |||
| { | |||
There was a problem hiding this comment.
It's a pity we aren't capturing metrics with the integration test right now, it would make this test much more useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
timed_outenhanced lambda metric for when a function crosses its timeout thresholdMotivation
Testing Guidelines
Integration Test - updated snapshots
Unittest - added a new test for time outs
Additional Notes
Types of changes
Check all that apply