Skip to content

Conversation

@tianchu
Copy link
Contributor

@tianchu tianchu commented Oct 28, 2020

What does this PR do?

Remove the following files from ddtrace, because they contain code like os.execl, which cause security scans to fail for certain customers. These files are not directly used by the Forwarder.

Motivation

Let security scans to pass for affected customers.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Copy link
Contributor

@hghotra hghotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tianchu tianchu merged commit 23f6e49 into master Oct 28, 2020
@tianchu tianchu deleted the tian.chu/strip-out-files-from-ddtrace branch October 28, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants