AZI-360 Make Log Forwarder default function app name unique #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiadadamo
approved these changes
Oct 1, 2021
| } | ||
|
|
||
| # Use values if parameters passed, otherwise we rely on the default value generated by the ARM template | ||
| if ($EventhubNamespace) { $deploymentArgs["eventhubNamespace"] = $EventhubNamespace } |
Contributor
There was a problem hiding this comment.
this is much cleaner :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To avoid clashing with other names, we now generate a globally unique one, similar to the Eventhub namespace name.
Also, use 'splatting' to add a hash table as parameters that we can build programmatically.
The parent ARM template was also changed as it overrides the function one, and the latter was changed in case an advanced user wants to invoke it by itself, so they remain whole and self-contained as much as possible.
Motivation
AZI-360
Testing Guidelines
Deployed both .ps1 scripts with the default and a set function app name, and saw they got deployed correctly on Azure side.
First in simulation mode with
-WhatIfand then a real deployment.Additional Notes
Types of changes
Check all that apply