Skip to content

Conversation

@iotmani
Copy link
Contributor

@iotmani iotmani commented Jul 19, 2022

What does this PR do?

Make partition count configurable in log forwarder automation.
Useful for adding more control to scaling the event hub as needed.

Motivation

AZI-62

Testing Guidelines

I deployed the parent template, with Event Hub partitionCount set to 28, and I could see it deployed correctly:
image
image

Additional Notes

Docs:
https://docs.microsoft.com/en-us/azure/templates/microsoft.eventhub/namespaces/eventhubs?tabs=json

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Copy link
Contributor

@ashwingandhi-ddog ashwingandhi-ddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iotmani I think you went over this in the demo, but why do we need this change in parent_template.json as well when its in event_hub.json ?

@iotmani
Copy link
Contributor Author

iotmani commented Jul 19, 2022

@iotmani I think you went over this in the demo, but why do we need this change in parent_template.json as well when its in event_hub.json ?

The event_hub.json is what deploys the eventhub and can technically be deployed independently if so desired.
The parent_template.json is the entry point for all resources/templates we want customers to be able to tweak, hence to allow them to override the default we'd need to expose another parameter there also, otherwise it would default to 32.

Think of it as just passing parameter x to function foo, which subsequently needs to call function bar. (and we don't have the ability to pass all kwargs like in Python :) ).

@iotmani iotmani merged commit 5acf5d5 into master Jul 19, 2022
@iotmani iotmani deleted the islam/partition-count-2 branch July 19, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants