Centralize metrics submission in the forwarder #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ge0Aja
force-pushed
the
georgi/enhanced_metrics
branch
4 times, most recently
from
7f4399d to
20f720c
Compare
ge0Aja
force-pushed
the
georgi/enhanced_metrics
branch
from
20f720c to
d2eda07
Compare
ViBiOh
approved these changes
Mar 25, 2024
| logger = logging.getLogger() | ||
| logger.setLevel(logging.getLevelName(os.environ.get("DD_LOG_LEVEL", "INFO").upper())) | ||
|
|
||
| try: |
Member
There was a problem hiding this comment.
That DD_SUBMIT_ENHANCED_METRICS bit is important I think
Contributor
Author
There was a problem hiding this comment.
We were not using it in the cache metrics submission, only in enhanced metrics.
Contributor
Author
There was a problem hiding this comment.
In any case I added the same check here
ge0Aja
force-pushed
the
georgi/enhanced_metrics
branch
from
c5ba0b4 to
1e036be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply