Refactor forwarding and logs classes in lambda forwarder #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ge0Aja
force-pushed
the
georgi/refactor_forwarder
branch
from
dcaf298 to
4a3a5ac
Compare
ge0Aja
changed the title
ge0Aja
force-pushed
the
georgi/refactor_forwarder
branch
from
4a3a5ac to
32218b2
Compare
ktmq
reviewed
Mar 25, 2024
| if len(trace_payloads) > 0: | ||
| forward_traces(trace_payloads) | ||
|
|
||
| forward(logs, metrics, trace_payloads) |
Contributor
There was a problem hiding this comment.
nit: What's the benefit of making this wrapper function? Something about it feels weird to me, partly because all these args are lists and it would be easy to mix up the order 🤔
Contributor
Author
There was a problem hiding this comment.
I'm actually refactoring this part because I'm working on adding a retry mechanism to be called if we fail to forward events in the case of failures on the intake side.
Therefore, I'm putting everything under a single function to be called from the retrier side.
Contributor
Author
There was a problem hiding this comment.
also there's a benefit from encapsulating the inner calls inside the module and expose less details outside.
RaphaelAllier
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply