Skip to content

Conversation

@ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Mar 27, 2024

What does this PR do?

Fix a bug that was introduced during a recent refactoring to handle SNS records on receiving S3 events.

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Mar 27, 2024
@ge0Aja ge0Aja changed the title Fix a bug in s3 handler to handle SNS records Fix a bug in log forwarder's s3 handler to properly handle SNS records Mar 27, 2024
@ge0Aja ge0Aja marked this pull request as ready for review March 27, 2024 17:24
@ge0Aja ge0Aja requested a review from a team as a code owner March 27, 2024 17:24
@ge0Aja ge0Aja force-pushed the georgi/s3_handler branch from c04bf96 to 94f3170 Compare March 28, 2024 07:49
@ge0Aja ge0Aja force-pushed the georgi/s3_handler branch from 94f3170 to 7ce3998 Compare March 28, 2024 09:38
@ge0Aja ge0Aja merged commit 1a5d1db into master Mar 28, 2024
@ge0Aja ge0Aja deleted the georgi/s3_handler branch March 28, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants